Explanation of Change

Fixed Issues

$ #96081
PROPOSAL:

Tests

USD - Manual - International details step shown

1. As an admin, enable Payments and do NOT setup a bank account
2. Enable Collect employee bank details
3. Add Austria as a business bank account country
4. As the member, go to Settings > Wallet > Add bank account
5. Select United States
6. Select Connect manually
7. Enter local US bank account details
8. Verify

• A new International bank account details step is shown after the initial details step
• The step has two required inputs: IBAN and SWIFT/BIC code

9. Enter a valid IBAN and SWIFT/BIC code and continue

• IBAN: US123456789012345678
• Swift code: XXXXUSXX

10. Verify the rest of the flow can be completed successfully

USD - Plaid - International details step shown

1. As an admin, enable Payments and do NOT setup a bank account
2. Enable Collect employee bank details
3. Add Austria as a business bank account country
4. As the member, go to Settings > Wallet > Add bank account
5. Select United States
6. Select Log into your bank
7. Log into Regions bank

• Username: user_good
• Password: pass_good

9. Select the savings account
10. Verify

• A new International bank account details step is shown after selecting the savings account
• The step has two required inputs: IBAN and SWIFT/BIC code

11. Enter a valid IBAN and SWIFT/BIC code and continue

• IBAN: US123456789012345678
• Swift code: XXXXUSXX

12. Verify the rest of the flow can be completed successfully

Intl’ - Manual - International details step shown

1. As an admin, enable Payments and do NOT setup a bank account
2. Enable Collect employee bank details
3. Add Belgium as a business bank account country
4. As the member, go to Settings > Wallet > Add bank account
5. Select Austria
6. Enter details:
7. IBAN: AT123456789012345678
8. Leave others empty
9. Continue
10. Verify

• The International bank account details step is shown
• The IBAN field is pre-filled with the value entered in the initial step
• The SWIFT/BIC code field is empty

11. Enter XXXXATXX for Swift code
12. Continue
13. Verify the rest of the flow can be completed successfully

Intl’ - Manual - International details step skipped

1. As an admin, enable Payments and do NOT setup a bank account
2. Enable Collect employee bank details
3. Add Austria as a business bank account country
4. As the member, go to Settings > Wallet > Add bank account
5. Select Austria
6. Enter details:

• IBAN: AT123456789012345678
• Leave others empty

7. Continue
8. Verify

• The International bank account details step is NOT shown

• The rest of the flow can be completed successfully and the personal bank account is added

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos